Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6607 Fix Admin Console OSGi imports and Fragments #6285

Merged
merged 1 commit into from
May 26, 2023

Conversation

Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented May 23, 2023

Description

Fixes loading of the admin console following on from the name changes in #6246
Without this, loading the admin console fails with the following error:

com.sun.enterprise.module.ResolveError: Not able to locate a unique module by name fish.payara.server.internal.admingui.console-common

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Loaded the admin console

Testing Environment

Windows, Zulu 11.0.19

Documentation

N/A

Notes for Reviewers

I'm unsure ATM if we need to define the bundle version as something other than ${project.osgi.version} - I guess we'll find out when we attempt to diverge the versions in the future.

@Pandrex247 Pandrex247 requested a review from pdudits May 23, 2023 15:56
@Pandrex247
Copy link
Member Author

Jenkins test please

@Pandrex247 Pandrex247 merged commit 37cb0ff into payara:master May 26, 2023
@Pandrex247 Pandrex247 deleted the FISH-6607 branch May 26, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants