Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-7341 Upgrade ASM from 9.4 to 9.5 to allow running on Java 21 #6267

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

eirbjo
Copy link
Contributor

@eirbjo eirbjo commented Apr 19, 2023

Description

Upgrading to the latest version of ASM allows Payara 5 to run on the latest Java 21.

Testing

Testing Performed

Tested by replacing asm-* jars with their respective 9.5 versions downloaded from Maven Central. Ran Payara 5 with an internal build of Java 21 and verified that the server starts and can deploy applications.

Testing Environment

macOS 12.6.3

Notes for Reviewers

I noticed the statement that no further community releases will be made from Payara 5, but considered this useful anyway in case someone wants to build from source. Also, this could be applied to any Enterprise offerings.

@JamesHillyard
Copy link
Member

Hi @eirbjo

Thank you for the PR, we're happy to receive your contribution, as you said yourself there will be no future releases of Payara 5 Community, however we would like to accept this PR and port it to Payara 6 as well as Enterprise distributions.

Before we can proceed, you will need to sign the CLA and send it to us. Payara/PayaraCLA.pdf at master · payara/Payara

I have raised an issue internally, FISH-7341, to track your contribution however we will not be able to accept or review your changes until the CLA has been signed.

Thank you,
James

@JamesHillyard JamesHillyard added the PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. label Apr 20, 2023
@JamesHillyard JamesHillyard changed the title Upgrade ASM from 9.4 to 9.5 to allow running on Java 21 FISH-7341 Upgrade ASM from 9.4 to 9.5 to allow running on Java 21 Apr 20, 2023
@eirbjo
Copy link
Contributor Author

eirbjo commented Apr 20, 2023

I have raised an issue internally, FISH-7341, to track your contribution however we will not be able to accept or review your changes until the CLA has been signed.

Thanks! I have signed and emailed the CLA.

@smillidge smillidge added PR: CLA CLA submitted on PR by the contributor and removed PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. labels Apr 20, 2023
@smillidge
Copy link
Contributor

CLA received

@aubi
Copy link
Contributor

aubi commented Jun 6, 2023

Jenkins test please

Copy link
Contributor

@aubi aubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs well on both Java 11 and 21, I tried some applications.

I tried running Payara samples on Java 11 against server running on Java 21 - no problem.

Server running on Java 21 and samples on Java 21 -- there was a problem with appserver/tests/payara-samples/samples/rolesallowed-unprotected-methods/src/test/java/fish/payara/samples/rolesallowed/unprotected/methods/RemoteEjbClientIT.java - the lookup didn't find anything
java.lang.NullPointerException: Cannot invoke "com.sun.enterprise.naming.impl.SerialContextProvider.lookup(String)" because "prvdr" is null

@aubi aubi merged commit 01334b5 into payara:Payara5 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants