FISH-1204 Missing example values in OpenApi components schema definition using nested objects #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins tests please |
|
TCK test succeeded |
lprimak
suggested changes
Jul 2, 2021
...file/openapi/src/main/java/fish/payara/microprofile/openapi/impl/model/media/SchemaImpl.java
Outdated
Show resolved
Hide resolved
...rc/test/java/fish/payara/microprofile/openapi/test/app/application/DependantClassesTest.java
Outdated
Show resolved
Hide resolved
...pi/src/test/java/fish/payara/microprofile/openapi/test/app/application/RequiredAttrTest.java
Outdated
Show resolved
Hide resolved
lprimak
approved these changes
Jul 2, 2021
|
jenkins test |
lprimak
changed the title
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-1204 Missing example values in OpenApi components schema definition using nested objects
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit e0c842c Signed-off-by: JamesHillyard <[email protected]>
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
FISH-1204 Missing example values in OpenApi components schema definition using nested objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing description of properties of embedded objects, fix missing required flag for reference, issue #5151
Testing
New tests
Added one new test for dependent DTOs with @Schema annotation, one for required reference.
Testing Performed
Tested on /openapi -- contains full description of embedded properties and a required reference is referred.
The correct output is attached to the GH issue.