FISH-1509: Keep the order of lines in logging.properties file in a pre-determined order #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-determined order
|
jenkins test please |
|
jenkins test |
lprimak
approved these changes
Jun 18, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-1509: Keep the order of lines in logging.properties file in a pre-determined order
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 22, 2021
This reverts commit a44c233.
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
FISH-1509: Keep the order of lines in logging.properties file in a pre-determined order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The order of the mines in the logging.properties changes 'randomly' as it based on the hash of keys used in the Properties class. This PR keeps them in a certain order according to the following patterns
handlers
handlerServices
java.util.logging.ConsoleHandler.formatter
java.util.logging.FileHandler.*
com.sun.enterprise.server\.logging.GFFileHandler.*
com.sun.enterprise.server\.logging.SyslogHandler.*
log4j.logger.org.hibernate\.validator.util.Version
com.sun.enterprise.server\.logging.UniformLogFormatter.*
fish.payara.enterprise.server\.logging.PayaraNotificationFileHandler.*
fish.payara.deprecated.jsonlogformatter.underscoreprefix
(.*)?.level
If there are multiple entries that match a pattern, they are sorted alphabetically.
Important Info
Blockers
Testing
New tests
SortedLoggingPropertiesTest to test the sorting algorithm
Testing Performed
Manual testing using the asadmin set-log-attributes command and using Web Console.
Testing Environment
Zulu 8.52.0.23-CA-macosx (build 1.8.0_282-b08) on Mac 11.2.3 with Maven 3.6.3
Documentation
No Documentation required