FISH-1293 Disassociate ClusteredStore from tenants #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Hazelcast maps to tenant applications that may be later undeployed and would leave maps orphan, which in turn will lead to Hazelcast blocking calls to those maps - minor cleanup
|
jenkins test |
dmatej
approved these changes
Apr 8, 2021
aubi
pushed a commit
to aubi/Payara
that referenced
this pull request
Jan 3, 2022
…iation of Hazelcast maps to tenant applications (payara#5188) that may be later undeployed and would leave maps orphan, which in turn will lead to Hazelcast blocking calls to those maps - minor cleanup
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jan 31, 2022
…Hazelcast maps to tenant applications (payara#5188) that may be later undeployed and would leave maps orphan, which in turn will lead to Hazelcast blocking calls to those maps - minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug.
Tenant control associates all Hazelcast objects to their calling applications by default.
However, internal maps that belong to
ClusteredStoreshould not do this.This fix prevents it from associating thus preventing blocking by tenant control
when application is undeployed
pushing empty context in ClusteredStore to prevent association of Hazelcast maps to tenant applications
that may be later undeployed and would leave maps orphan, which in turn will lead
to Hazelcast blocking calls to those maps
minor cleanup
Testing
Testing Performed
Ran Payara Samples twice, which is how I discovered this bug in the first place
Review Notes
** Please use "ignore whitespace changes" to review,
otherwise it looks like changes don't make sense