Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FISH-1289 QACI-579] fix race condition with duplicate initialization of Micro ports #5184

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Apr 8, 2021

Description

Bug fix. Removes duplicate HTTP ports from Payara Micro. Fixes race condition on startup that causes duplicate ports.

Testing

Fixes Payara Micro Arquillian tests suites along with the release of Connectors 2.4.1

Testing Performed

MP TCK

Notes for Reviewers

As usual, use "ignore white space changes"

@lprimak lprimak changed the title [QACI-579[ fix race condition leading to duplicate initialization of Micro ports [QACI-579] fix race condition leading to duplicate initialization of Micro ports Apr 8, 2021
@lprimak lprimak requested review from smillidge and MattGill98 April 8, 2021 00:56
@lprimak lprimak changed the title [QACI-579] fix race condition leading to duplicate initialization of Micro ports [FISH-1289 QACI-579] fix race condition with duplicate initialization of Micro ports Apr 8, 2021
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- moved identity store addition code to @BeforeClass
- added Payara Client deps to samples test
- updated Arquillian to Alpha9
- update to Arquillian Connectors 2.4.1
- Updated surefire plugin to -M5
@lprimak
Copy link
Contributor Author

lprimak commented Apr 9, 2021

jenkins test

@lprimak lprimak merged commit b08f88b into payara:master Apr 9, 2021
@lprimak lprimak deleted the MicroPortDupl branch April 9, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants