Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5080 Payara logback libs produce NPE / FISH-1007 #5082

Merged
merged 3 commits into from
Jan 24, 2021
Merged

5080 Payara logback libs produce NPE / FISH-1007 #5082

merged 3 commits into from
Jan 24, 2021

Conversation

sgflt
Copy link
Contributor

@sgflt sgflt commented Dec 31, 2020

Fixes #5080

Description

Obviously javadoc says there may be null returned.

    /**
     * Returns the meta data for the given key
     *
     * @param metaDataKey key of the meta date.
     * @param metadataType type of the meta date.
     * @return instance of T or null
     */
     <T> T getTransientAppMetaData(String metaDataKey, Class<T> metadataType);

Important Info

Blockers

Testing

New tests

Testing Performed

Testing Environment

Documentation

Notes for Reviewers

@lprimak
Copy link
Contributor

lprimak commented Jan 2, 2021

jenkins test

@AlanRoth AlanRoth added PR: CLA CLA submitted on PR by the contributor Type: Community Contribution labels Jan 11, 2021
@AlanRoth AlanRoth self-assigned this Jan 11, 2021
@AlanRoth AlanRoth added the PR: DO NOT MERGE Don't merge PR until further notice label Jan 11, 2021
@AlanRoth
Copy link

Will need more testing, as a community user reported a regression with this fix.

@AlanRoth
Copy link

jenkins test please

@AlanRoth AlanRoth removed the PR: DO NOT MERGE Don't merge PR until further notice label Jan 14, 2021
@AlanRoth AlanRoth changed the title 5080 fix nullcheck 5080 fix nullcheck / FISH-1007 Jan 14, 2021
@AlanRoth AlanRoth changed the title 5080 fix nullcheck / FISH-1007 5080 Payara logback libs produce NPE / FISH-1007 Jan 14, 2021
@AlanRoth
Copy link

jenkins test please

@AlanRoth AlanRoth requested a review from rdebusscher January 20, 2021 09:14
@lprimak lprimak merged commit ab677c7 into payara:master Jan 24, 2021
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request May 4, 2021
@MattGill98
FISH-327 Implement MicroProfile Sniffers
7cf38c0 
Merge pull request payara#4966 from MattGill98/FISH-327
Merge pull request payara#5130 from MattGill98/FISH-760
Merge pull request payara#5025 from MattGill98/FISH-863
5080 Payara logback libs produce NPE / FISH-1007 (payara#5082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lprimak lprimak lprimak approved these changes

@MattGill98 MattGill98 Awaiting requested review from MattGill98

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

@rdebusscher rdebusscher Awaiting requested review from rdebusscher

Assignees

@AlanRoth AlanRoth

Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payara logback libs NPE / FISH-1007
3 participants
@sgflt @lprimak @AlanRoth