Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-657 fixed wstx-services deployment errors #4974

Merged
merged 2 commits into from
Nov 13, 2020
Merged

FISH-657 fixed wstx-services deployment errors #4974

merged 2 commits into from
Nov 13, 2020

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 2, 2020

Description

Fixes web services deployment bug (sporradic)

Important Info

Blockers

none

Testing

New tests

QuickLook tests pass now,
no exception such as this:

ava.lang.IllegalArgumentException: no <deploymentgroup> element
    at com.sun.enterprise.config.serverbeans.Domain$Duck.getDeploymentGroupNamed(Domain.java:672)
    at sun.reflect.GeneratedMethodAccessor88.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.jvnet.hk2.config.Dom.invokeDuckMethod(Dom.java:1129)
    at org.jvnet.hk2.config.Dom.invoke(Dom.java:1080)
    at org.glassfish.config.support.TranslatedConfigView.invoke(TranslatedConfigView.java:208)
    at com.sun.proxy.$Proxy82.getDeploymentGroupNamed(Unknown Source)
    at org.glassfish.ejb.startup.EjbDeployer.event(EjbDeployer.java:472)
    at org.glassfish.kernel.event.EventsImpl.send(EventsImpl.java:131)
    at com.sun.enterprise.v3.server.ApplicationLifecycle.prepare(ApplicationLifecycle.java:562)

Testing Performed

QuickLook tests

Testing Environment

Mac, JDK 8

Documentation

Notes for Reviewers

@lprimak
check for null target inside the deploy command, could happen with in…
78bb3ff 
…ternal apps, such as wstx-services or admin console
@lprimak
Copy link
Contributor Author

lprimak commented Nov 2, 2020

jenkins test

1 similar comment
@lprimak
Copy link
Contributor Author

lprimak commented Nov 2, 2020

jenkins test

rdebusscher
rdebusscher approved these changes Nov 3, 2020
View reviewed changes
Copy link

@rdebusscher rdebusscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lprimak
Copy link
Contributor Author

lprimak commented Nov 3, 2020

jenkins test

1 similar comment
@lprimak
Copy link
Contributor Author

lprimak commented Nov 8, 2020

jenkins test

@lprimak
Copy link
Contributor Author

lprimak commented Nov 12, 2020

jenkins test

1 similar comment
@lprimak
Copy link
Contributor Author

lprimak commented Nov 12, 2020

jenkins test

@MattGill98 MattGill98 merged commit 5ab8aa0 into payara:master Nov 13, 2020
@lprimak lprimak deleted the Deployment-Groups-NPE-FISH-657 branch November 28, 2020 05:26
Cousjava pushed a commit to Cousjava/Payara that referenced this pull request Jan 27, 2021
@lprimak @MattGill98
Merge pull request payara#4974 from flowlogix/Deployment-Groups-NPE-F…
c26c190 
…ISH-657 (payara#241)

FISH-657 fixed wstx-services deployment errors

Co-authored-by: Matt Gill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svendiedrichsen svendiedrichsen svendiedrichsen left review comments

@jbee jbee jbee approved these changes

@rdebusscher rdebusscher rdebusscher approved these changes

@pdudits pdudits Awaiting requested review from pdudits

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lprimak @jbee @rdebusscher @svendiedrichsen @MattGill98