Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-320 Remove Hipchat Notifier #4912

Merged
merged 2 commits into from
Sep 28, 2020
Merged

FISH-320 Remove Hipchat Notifier #4912

merged 2 commits into from
Sep 28, 2020

Conversation

MattGill98
Copy link
Contributor

@MattGill98 MattGill98 commented Sep 25, 2020

Hipchat is no longer usable, so all the hipchat related code can be removed.

- Change configure- command syntax to more common set- syntax.
- Fix remaining compilation issues.

Signed-off-by: Matthew Gill <[email protected]>
@MattGill98 MattGill98 self-assigned this Sep 25, 2020
@MattGill98
Copy link
Contributor Author

jenkins test please

@Cousjava
Copy link
Contributor

Cousjava commented Sep 25, 2020

The hipchat notifier could just be removed with any changes, as Hipchat is discontinued in all versions now. See ZDEP-3906.

Hipchat isn't usable anymore, so the notifier is no longer usable
either.

Signed-off-by: Matthew Gill <[email protected]>
@MattGill98 MattGill98 changed the title FISH-320 Update Hipchat Notifier to New API FISH-320 Remove Hipchat Notifier Sep 25, 2020
@MattGill98
Copy link
Contributor Author

MattGill98 commented Sep 25, 2020

@Cousjava issue has been rescoped, please review again

@MattGill98
Copy link
Contributor Author

jenkins test please

@MattGill98 MattGill98 merged commit 0756d98 into payara:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants