FISH-392 Fix Trace getting started when Request Tracing is Disabled #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Cousjava
approved these changes
Sep 3, 2020
|
jenkins test please |
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Oct 13, 2020
FISH-392 Fix Trace getting started when Request Tracing is Disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix.
OpenTracingIiopServerInterceptor starts a trace even if request tracing is disabled - this is inconsistent with the behaviour of opentracing and request tracing everywhere else.
Testing
Ran the remote-ejb-tracing sample. Before it didn't enable request tracing and would still pass against a clean domain - with the changes in this PR it should fail against a clean domain so I've added extra setup and teardown steps to the test.