Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-219 Indicate missing default value when using custom template for domain creation #4773

Merged
merged 1 commit into from
Jul 8, 2020
Merged

FISH-219 Indicate missing default value when using custom template for domain creation #4773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/LocalStrings.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ MutuallyExclusiveOption=CLI169: Options {0} and {1} are mutually exclusive. You
UnsupportedLegacyCommand=CLI194: Previously supported command: {0} is not supported for this release.
NoScope=CLI195: Implementation for the command {0} exists in the system,\nbut it has no @Scoped annotation
HasParams=CLI196: Implementation for the command {0} exists in the system,\nbut it's a singleton that also has parameters
MissingDefaultPort=No (default) value specific for {0}

###
listCommands.notBoth=You can't specify both --localonly and --remoteonly as true at the same time.
Expand Down
3 changes: 3 additions & 0 deletions ...er-mgmt/src/main/java/com/sun/enterprise/admin/servermgmt/domain/DomainPortValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,9 @@ else if (properties != null) {
portNotSpecified = true;
}
if (portNotSpecified) {
if (defaultPort == null || defaultPort.trim().isEmpty()) {
throw new DomainException(STRINGS.get("MissingDefaultPort", key));
}
port = convertPortStr(defaultPort);
defaultPortUsed = true;
}
Expand Down