FISH-56 OpenAPI document doesn't use @Schema when class is in jar dependency of the project #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency of the project Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
jGauravGupta
requested review from
rdebusscher and
MattGill98
and removed request for
rdebusscher
|
jenkins test please |
MattGill98
approved these changes
Jul 7, 2020
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Jan 27, 2021
FISH-56 OpenAPI document doesn't use @Schema when class is in jar dependency of the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gupta [email protected]
Description
This is a bug fix that dynamically picks and scans
@Schemaclass, if not found in the list of selected classes for OpenAPI metadata processing but exists in the classpath.Important Info
Testing
New tests
Unit test
Payara/appserver/payara-appserver-modules/microprofile/openapi/src/test/java/fish/payara/microprofile/openapi/test/app/application/ExternalSchemaExampleTest.java
Line 68 in 1bcbbd2
Testing Performed
Unit tests
MP OPEN API TCK Runner
Testing Environment
Windows 10, JDK 11.0