APPSERV-151 Command to Generate a CSR #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbee
reviewed
Jun 5, 2020
...t/src/main/java/fish/payara/certificate/management/CertificateManagementKeytoolCommands.java
Show resolved
Hide resolved
...t/src/main/java/fish/payara/certificate/management/CertificateManagementKeytoolCommands.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/fish/payara/certificate/management/CertificateManagementKeytoolCommands.java
Show resolved
Hide resolved
| * @throws MiniXmlParserException If there's an issue reading the domain.xml | ||
| * @throws CommandException If there's an issue getting the master password | ||
| */ | ||
| private void getStorePasswords(MiniXmlParser parser, String listener, File serverDir) |
There was a problem hiding this comment.
At some point it would be nice to move all the XML processing to one place. Maybe not now.
...ificate-management/src/main/manpages/fish/payara/certificate/management/admin/generate-csr.1
Outdated
Show resolved
Hide resolved
...ificate-management/src/main/manpages/fish/payara/certificate/management/admin/generate-csr.1
Show resolved
Hide resolved
jbee
approved these changes
Jun 5, 2020
|
jenkins test please |
|
Database error? Que? |
|
Jenkins test please |
|
jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a command to generate a CSR from the key store of a target instance or listener, placing the resultant CSR file under
payara5/glassfish/tls/${alias}.csrImportant Info
Based off of #4694.
This PR actually only consists of three commits:
Testing
New tests
None
Testing Performed
Manually ran:
Testing Environment
Windows 10, JDK 8
Notes for Reviewers
To build please specify the BuildExtras profile and manually copy-pasta the Jar from appserver/extras/certificate-management/ into the payara5/glassfish/lib/asadmin directory.