Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPSERV-124 Monitoring-Console: Adds server side page configuration #4666

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

jbee
Copy link
Contributor

@jbee jbee commented May 12, 2020

Summary

This PR adds the page names (IDs) and values to the server side monitoring console configurations which is used by payara/monitoring-console#11 to provide a fully integrated server side page configuration for MC. Requires payara/monitoring-console#11 and payara/monitoring-console#15 to be merged first and release 1.2 of MC implementation made.

Testing

Assuming MC changes are released (or build locally) build this PR and install it.

  • start server
  • enable monitoring console
  • open monitoring console webapp in the browser
  • clear browsers local storage for the page
  • refresh the page, check the role selection popup is shown

mc_dia_role

  • select User role
  • check that the page synchronisation popup is shown

mc_dia_pages

  • with no previous pages shared the list should be empty. press update or cancel.
  • change the core page (e.g. add or remove a widget), open settings and expand the Page settings, click Push button.
  • open MC in another browser, the page synchronisation now should show the changed and pushed page

Now the basic principle of page synchronisation was tested. There are many possible scenarios from here using the different roles.

As a Guest the idea is that by default all updates shared by other are applied at the beginning so you work with the latest persistent settings. Guests change their local pages but don't share any changes. Buttons to push are not available. Automatic pushes do not occur.

As a User the idea is that by default all updates are applied as long as they do not override a page that has been changed locally. This is reflected in the checkbox being checked or not by default when doing the page synchronisation. Obviously users can chose which pages to override or not. User can also manually push pages to the persistent configuration by using the Push button in the Page Sync setting.

As an Administrator the idea is that the role is used to configure the configuration that acts as base for other users. When pulling changes defaults work similar to users. But any change done to local page is automatically shared (pushed) when the Page Sync auto setting is checked for the modified page (which it is by default). Administrator can also explicitly update already shared paged by using the Update Remote Pages button in the Global Page Sync settings or push an individual page explicitly by using the Push button (same as users).

Note also that once a user preferred a locally changed page over a remotely updated one this choice is considered in later updates by default that page will not be updated as long as the remote page is not updated with an even newer version.

In general "versions" are identical to moment of change. More recent changes are considered newer.

See also the documentation payara/Payara-Community-Documentation#6

@jbee
Copy link
Contributor Author

jbee commented Jun 1, 2020

Jenkins test please

@jbee jbee merged commit 6310c3f into payara:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants