Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-265 Restarting the domain with the Payara log formatter causes the log to rotate #4634

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

Cousjava
Copy link
Contributor

Description

This is a bug fix.

If Payara Server is restarted with the JSON log formatter then the logs would always rotate.

Testing

New tests

New test file added in this commit.

Testing Performed

Tested by restarting the server and checking that no new additional log files are created.

Testing Environment

Zulu JDK 1.8_212 on Ubuntu 18.04 with Maven 3.6.0

@Cousjava Cousjava added this to the 5.202 milestone Apr 20, 2020
@Cousjava Cousjava requested a review from MeroRai April 20, 2020 21:23
@Cousjava
Copy link
Contributor Author

Jenkins test please

Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, and test passed. It is in conflict with CUSTCOM-55, but no problem, I will rebase my branch.

@dmatej
Copy link
Contributor

dmatej commented Apr 21, 2020

Jenkins test please

@Cousjava Cousjava closed this Apr 21, 2020
@Cousjava Cousjava reopened this Apr 21, 2020
@dmatej dmatej merged commit ca93e01 into payara:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants