CUSTCOM-194 The delete-jvm-options command shouldn't require to specify the Java version prefix #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy the Java version prefix
|
Jenkins test please |
rdebusscher
suggested changes
Mar 23, 2020
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/commands/DeleteJvmOptions.java
Show resolved
Hide resolved
|
Jenkins test please |
rdebusscher
approved these changes
Mar 24, 2020
MarkWareham
pushed a commit
to MarkWareham/Payara
that referenced
this pull request
Apr 3, 2020
CUSTCOM-194 The delete-jvm-options command shouldn't require to specify the Java version prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix to fix an issue where the
delete-jvm-optionscommand required the specify Java version prefix to execute successfully.Testing
New tests
None
Testing Performed
Build test
Manually tested the
delete-jvm-optionscommand with and without the Java version prefix with the following commands:./asadmin delete-jvm-options '[Azul-1.8.0u222|1.8.0u500]-XX\:+UseOpenJSSE'./asadmin delete-jvm-options '-XX\:+UseOpenJSSE'Testing Environment
Documentation
Not required