APPSERV-54 Print a Warning if No Encryption Key Present #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 15, 2020
APPSERV-54 Print a Warning if No Encryption Key Present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prints a warning on the command line and in the admin console when enabling data grid encryption when a key can't be found.
Testing
From a clean domain, simply run
set-hazelcast-configuration --encryptdatagrid trueand you should get a warning.You should get a similar warning when attempting to do the same from the admin console: Domain > Data Grid.
New tests
New asadmin test added to existing
SetHazelcastConfigurationTestin payara-samples.Checks that a warning is given when enabling datagrid encryption without generating a key.
Notes for Reviewers
Touching such a fundamental method in the admin console (
updateEntity) worries me a bit, as this can easily ripple outwards in unforeseen ways. I've poked around the admin console and haven't managed to make it throw a wobbly but I can't poke everything.