CUSTCOM-260 Fixed possible deadlock in StandardSession #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- see javadoc in Session interface
- improves encapsulation of parent class
- partially fixes cyclic dependency between SingleSignOnEntry:121 and BaseHASession:239
- isValid has side effect described in Session interface - we cannot break contract
rdebusscher
added
the
PR: Awaiting CLA
|
@sgflt We are awaiting the signed CLA (https://github.com/payara/Payara/blob/master/PayaraCLA.pdf) otherwise we need to close this PR. |
rdebusscher
added
the
Status: Abandoned
dmatej
approved these changes
Apr 3, 2020
|
CLA on the way :) |
smillidge
added
PR: CLA
|
We've got the CLA |
rdebusscher
added
community-contribution
and removed
Status: Abandoned
|
Jenkins test please |
dmatej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix of deadlock described in #4281
I could not create simple reproducer because race conditions are hard to reproduce.
EDIT dmatej: the possible deadlock is well visible from sources.
Notes for Reviewers
Reviewer should proove that the cycle between classes existed in previous version and now is fixed correctly.
@dmatej