APPSERV-27 Allow Temp/Unmanaged Docker Node instance to Join a Deployment Group on Creation #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a feature to allow Temp/Unmanaged Docker Node instance to Join a Deployment Group on Creation. When creating temporary docker node instances using either the Docker Rest API or Docker CLI, the only way to have an instance join a deployment group upon creation is for you to use a custom Docker image.
With this PR you can specify a Docker Env variable,
PAYARA_DEPLOYMENT_GROUPwhich would then be read and used upon instance creation.Testing
Testing Performed
Created a Docker image using the newly updated
entrypoint.sh. Using the Docker image created a container with thePAYARA_DEPLOYMENT_GROUPDocker Env variable.Testing Environment
Zulu JDK 1.8_222 on Elementary OS 0.4.1 Loki with Maven 3.5.4
Documentation
TODO