CUSTCOM-144 Avoid NPEx on unboxing null Boolean (javaee/glassfish 22406) #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-ee4j/glassfish 22406
|
jenkins test please |
Cousjava
approved these changes
Jan 8, 2020
Cousjava
changed the title
dmatej
approved these changes
Jan 9, 2020
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <version>${mockito.version}</version> |
There was a problem hiding this comment.
Version and scope are redundant, they are already defined in payara-nucleus-parent, am I right?
There was a problem hiding this comment.
Answer to myself: no, not in master yet ...
There was a problem hiding this comment.
Answer to myself: no, not in master yet ...
But I have such change waiting on my branch! Really! 😄
There was a problem hiding this comment.
Version and scope are redundant, they are already defined in payara-nucleus-parent, am I right?
I've just proposed #4418 to make it so.
There was a problem hiding this comment.
You are too fast, now I will have some conflicts, but nevermind, they will be trivial ;)
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix, for issue originally reported against javaee/glassfish (22406).
Testing
New tests
New UT
FilterDefDecoratorTest.nullAsyncSupportedFlagShallNotCauseException.Testing Performed
A.
mvn clean installFilterDefDecoratorand doesn't break the build in other parts.B. With distribution built in step A2 - Steps to reproduce from 22406, but with step 7 producing expected welcome page.
Test suites executed
Only included in full build with command above.
Testing Environment
A. Ubuntu 16.04.6 LTS, OpenJDK Runtime Environment (build 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10), maven 3.6.3
B. GNU/Linux, OpenJDK Runtime Environment (build 1.8.0_232-b09), maven 3.6.3