Thread Naming for easier Thread Dump analysis - CUSTCOM-145 #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdebusscher
commented
Jan 1, 2020
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/JobCleanUpService.java
Show resolved
Hide resolved
rdebusscher
changed the title
Cousjava
approved these changes
Jan 8, 2020
dmatej
suggested changes
Jan 9, 2020
nucleus/common/common-util/src/main/java/com/sun/common/util/logging/LoggingOutputStream.java
Show resolved
Hide resolved
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/JobCleanUpService.java
Show resolved
Hide resolved
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/JobCleanUpService.java
Show resolved
Hide resolved
dmatej
approved these changes
Jan 9, 2020
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/JobCleanUpService.java
Show resolved
Hide resolved
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUSTCOM-145: Assign meaningful thread names
During Thread dump analysis, it was not always easy to identify what threads are due to their name (Thread-[n] or pool-[x]-thread-[y])
After this update, threads name are mostly set. Some threads are still un named and could be done in
osgi-javaee-base org.glassfish.osgijavaeebase.ExtenderManager.GlassFishServerTracker#addingService
org.glassfish.osgijavaeebase.JavaEEExtender.HybridBundleTrackerCustomizer#addingBundle
and Apache Felix
Description
This is a improvement
Should be easier to identify threads in Thread Dump.
Testing
Testing Performed
Manual testing to identify the list of threads through JConsole.
Test suites executed
Testing Environment
Mac OS