CUSTOM-54: NullPointerException when JMX attribute is null

[rdebusscher]

CUSTOM-54: NullPointerException when JMX attribute is null within the rest-monitoring endpoint

Description

This is a bug fix

When JMX attributes are null, it results in NPE when accessed from the rest-monitoring endpoint.

The fix checks if the attribute value is null and return JsonValue.NULL in that case instead of the 'generic' method who tries to convert the instance to a JsonValue.

Testing

Testing Performed

Manual testing

• /asadmin start-domain
• deploy simple jms example (https://github.com/payara/Payara-Examples/tree/master/javaee/simple-jms-example)
• ./asadmin set-monitoring-level --level=HIGH --module=jmsService --target=server-config
• ./asadmin set-amx-enabled --dynamic=true --enabled=true --target=server-config
• ./asadmin set-monitoring-service-configuration --mbeanEnabled=true --monitoringEnabled=true --dtraceEnabled=false --target=server-config
• ./asadmin set-rest-monitoring-configuration --securityenabled=false --contextroot=/rest-monitoring --enabled=true --applicationname=__restmonitoring --target=server-config
• http://localhost:4848/rest-monitoring/rest/read/com.sun.messaging.jms.server:type=Destination,subtype=Monitor,desttype=q,name="simpleQ"

Testing Environment

Oracle 1.8.0_181 on Mac 10.14.6 with Maven 3.5.4

Documentation

N/A

[rdebusscher]

@MarkWareham Added Unit tests

[dmatej]

Test was successful, not sure with AssertJ usage, but ok.

[pzygielo]

Why not use the same version and from jakarta as

Payara/pom.xml

Line 186 in 2e6edd2

<jsonp.version>1.1.5</jsonp.version>

seems to be used for example in

Payara/api/payara-bom/pom.xml

Lines 798 to 802 in 2e6edd2

	<dependency>
	<groupId>org.glassfish</groupId>
	<artifactId>jakarta.json</artifactId>
	<version>${jsonp.version}</version>
	</dependency>

[rdebusscher]

I though the org.glassfish:jakarta.json pointed to the API, and not an actual implementation., as only the API artifacts should be 'jakartified'.
Fixed in new commit.

[rdebusscher]

jenkins test please