Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-27: Fix that steady-pool-size can be 0 #4357

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

sergitrujillo
Copy link

Description

This is a bug fix
#4197

Notes for Reviewers

It's my first pull request to payara. Sorry if if did some mistake in some convenion.

@jbee
Copy link
Contributor

jbee commented Dec 3, 2019

jenkins test please

@jbee
Copy link
Contributor

jbee commented Dec 3, 2019

@smillidge Do we need a CLA for this small of a change?

@smillidge
Copy link
Contributor

No that's too small and obvious to be covered by copyright.

@jbee
Copy link
Contributor

jbee commented Dec 3, 2019

@rdebusscher you seemed to know the context of PAYARA-4205 - maybe you can have a look and see if the change is the solution you were looking for in your comments.

@dmatej
Copy link
Contributor

dmatej commented Dec 3, 2019

It is rather PAYARA-4207, 4205 was about the error message. Both issues should join in correct solution = correct check allowing zero steady pool size and correct error message.
I will finish the test case for that tomorrow (if Rudy does not already have some)

@rdebusscher
Copy link

@jbee The PR is good for the fix of the steady pool size. The 'issue' that we perform 2 checks (maxPoolSizeValue should be larger then steadyPoolSizeValue and values larger then 0) and show only 1 error message still needs to be addressed.

@dmatej dmatej changed the title PAYARA-4205: Fix that steady-pool-size can be 0 CUSTCOM-27: Fix that steady-pool-size can be 0 Dec 4, 2019
@dmatej dmatej self-assigned this Dec 6, 2019
@dmatej dmatej self-requested a review December 6, 2019 07:24
@dmatej
Copy link
Contributor

dmatej commented Dec 6, 2019

Tested both with asadmin and DAS UI.

@dmatej dmatej merged commit 5f343ad into payara:master Dec 6, 2019
@sergitrujillo sergitrujillo deleted the PAYARA-4205 branch December 6, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants