PAYARA-4253 PAYARA-4060: Replace remaining JAVA EE api artifacts with Jakarta EE's #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javax artifacts still pop up on compilation classpaths as implementation dependencies, but the final distributions are javax api-free
Caused asadmin to miss validation classes, although it needs them
Bundle name of jakarta artifact still refers to javax
|
Jenkins test please |
Cousjava
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a feature.
All remaining
javaxAPI classes were replaced with their jakarta counterparts. Since some of the third party implementations still depend on original APIs, they may appear on classpath here and there, but the resulting distribution is javax-free.After changes in module names, jsp compilation paths in
default-web.xmlhad to be updated. Hibernate Validator pulling Java EE validation API resulted in wrong classpath ofasadmin, and therefore that dependency needed be excluded.Testing
Testing Performed
Full run of Jakarta EE TCK (and then focused tests for failures until fixed)
Click through asadmin ui
Test suites executed
Testing Environment
Zulu JDK 1.8_222 on Ubuntu 18.04 with Maven 3.6.0