PAYARA-4118 Speedup Payara shutdown by having GFFileHandler use its o… #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Jenkins test please |
…wn thread GFFileHandler no longer uses PayaraExecutorService This is a partial revert of f60de6a / payara#3437
Cousjava
force-pushed
the
PAYARA-4118-speedup-shutdown
branch
from
4ddcf7f to
5dc63c6
Compare
|
Jenkins test please |
MarkWareham
approved these changes
Oct 4, 2019
Pandrex247
changed the title
pdudits
reviewed
Oct 7, 2019
Comment on lines
-606
to
-607
| drainAllPendingRecords(); | ||
| flush(); |
There was a problem hiding this comment.
What about this code branch? Shouldn't it remain in the block?
By the way using new Thread(Runnable) would allow you to retain original lambda.
|
|
||
| public static LogRotationTimer getInstance() { | ||
| return instance; | ||
| } | ||
|
|
||
| public void startTimer(ScheduledExecutorService scheduledExecutorService, LogRotationTimerTask timerTask) { |
There was a problem hiding this comment.
On the other hand, this was task very fit for payara executor service, as it is very infrequent timed one
Pandrex247
reviewed
Oct 7, 2019
| pumpFuture = payaraExecutorService.submit( | ||
| () -> { | ||
| while (!done.isSignalled() && logToFile) { | ||
| pump = new Thread() { |
There was a problem hiding this comment.
It might be worth putting in a comment explaining why we're not using a the managed executor service here so that we don't come back to this in a year's time and go "why is that not using a managed executor?"
|
Jenkins test please |
Pandrex247
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a performance imporvement
reverts #3437
Due to the behaviour of GFFileHandler logpump it is better for it to be in it's own thread rather than use the executor service, having it as part of the executor service causes it to carry on running until killed.
Testing
New tests
None
Testing Performed
Ran the command
asadmin start-domain --verbose --debug && date +"%Y-%m-%d %H:%M:%S.%3Nto print out time with milliseconds after domain is stopped, and compared that time with time that server shutdown was started.Time before PR - 6.398 seconds
Time with 4ddcf7f - 1.235 seconds
Test suites executed
Testing Environment
"Zulu JDK 1.8_222 on Ubuntu 19.04 DIsco Dingo with Maven 3.6.0"-->