PAYARA-4096 Allow generating instance names from the Admin Console #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
jGauravGupta
approved these changes
Sep 3, 2019
jGauravGupta
reviewed
Sep 3, 2019
| @@ -0,0 +1,35 @@ | |||
| package fish.payara.cluster.admingui; | |||
MeroRai
reviewed
Sep 4, 2019
| @@ -38,4 +38,4 @@ | |||
| # holder. | |||
| # | |||
|
|
|||
| @@ -51,6 +51,8 @@ | |||
| <sun:button id="newButton" text="$resource{i18n.button.OK}" | |||
There was a problem hiding this comment.
Portions Copyright header needs updating.
|
@Pandrex247 Tested it locally everything works fine. The only feedback I have is Auto Name could benefit form help text. |
MarkWareham
changed the title
|
Jenkins test please |
MeroRai
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
I've had to remove the required label, so the prompt has changed a little from a text box to a full error message. From my testing this hasn't changed the functionality of the page at all, it's merely aesthetic.