PAYARA-3850 Data collection API and sources #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
jGauravGupta
requested changes
Aug 2, 2019
...ules/microprofile/metrics/src/main/java/fish/payara/microprofile/metrics/MetricsService.java
Outdated
Show resolved
Hide resolved
...ules/microprofile/metrics/src/main/java/fish/payara/microprofile/metrics/MetricsService.java
Outdated
Show resolved
Hide resolved
jGauravGupta
reviewed
Aug 2, 2019
...hcheck-checker/src/main/java/fish/payara/healthcheck/mphealth/MicroProfileHealthChecker.java
Outdated
Show resolved
Hide resolved
|
jenkins test please |
Pandrex247
approved these changes
Aug 5, 2019
jGauravGupta
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Introduces a new API to collect monitoring data consisting of two interface:
MonitoringDataSourcea@Contractimplemented by@Serviceclasses that have references to monitoring data in some formMonitoringDataCollectoris passed to the sources so they can add any number of data points.Data points are added in in a collection context that is implicit for the
MonitoringDataCollectorand can be extended using itstagmethod to create a new extended collection context.The majority of actual code are the implementations of the
MonitoringDataSources where the different services add their information to the collection.More details can be found in the design document https://payara.atlassian.net/wiki/spaces/PAYAR/pages/870055939/Payara+Monitoring+Console+Design