Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3884 Payara Micro adds JDK 11 warning when exploded application deployed #4120

Merged
merged 2 commits into from
Aug 14, 2019
Merged

PAYARA-3884 Payara Micro adds JDK 11 warning when exploded application deployed #4120

merged 2 commits into from
Aug 14, 2019

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Aug 2, 2019

jvm-options in domain.xml is not used by Payara Micro and not applicable as Payara Micro is not executing in a separate JVM.

        <jvm-options>[9|]--add-opens=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-exports=java.base/jdk.internal.ref=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-opens=java.base/java.lang=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-opens=java.base/java.nio=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-opens=java.base/sun.nio.ch=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-opens=java.management/sun.management=ALL-UNNAMED</jvm-options>
        <jvm-options>[9|]--add-opens=java.base/sun.net.www.protocol.jrt=ALL-UNNAMED</jvm-options>

Hence either the end-user should pass the --add-opens and/or --add-exports command-line flag when running the JAR or these flags can be added to Payara Micro META-INF/MANIFEST.MF file:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.6.5
Created-By: 25.172-b11 (Oracle Corporation)
Bundle-SymbolicName: fish.payara.micro
Main-Class: fish.payara.micro.PayaraMicro
Start-Class: fish.payara.micro.impl.PayaraMicroImpl
Add-Exports: java.base/jdk.internal.ref
Add-Opens: java.base/jdk.internal.loader java.base/java.lang java.base
 /java.nio java.base/sun.nio.ch java.management/sun.management jdk.man
 agement/com.sun.management.internal java.base/sun.net.www.protocol.jrt

** These flgas are ignored when runnging on JDK 8 (or less).

@jGauravGupta jGauravGupta added this to the 5.193 milestone Aug 2, 2019
@jGauravGupta
Copy link
Contributor Author

jenkins test please

@Pandrex247 Pandrex247 merged commit 862e6cf into payara:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants