PAYARA-4015 Module admingui/common-console replaced synchronized classes... #4096
Conversation
There was a problem hiding this comment.
Thanks @svendiedrichsen for the PR, only a few minor naming issues and suggestions.
| private static String[] getSelectedCiphersList(String selectedCiphers){ | ||
| List<String> selItems = new ArrayList<>(); | ||
| if(selectedCiphers != null){ | ||
| String[] sel = selectedCiphers.split(","); //NOI18N |
There was a problem hiding this comment.
We try to avoid short names or abbreviations for variable names. Maybe this can just be inlined in the for loop?
| Vector ciphersVector = null; | ||
| Object ciphers = (Object)handlerCtx.getInputValue("ciphers"); | ||
| List<String> ciphersList = null; | ||
| Object ciphers = handlerCtx.getInputValue("ciphers"); | ||
| if (ciphers != null) { | ||
| if (ciphers instanceof String) { | ||
| String[] ary = getSelectedCiphersList((String) ciphers); |
There was a problem hiding this comment.
Inline to avoid short variable name?
| return sb.toString(); | ||
| } | ||
|
|
||
| private static List<String> getCiphers(String[] allCiphers){ |
There was a problem hiding this comment.
Couldn't this method be replaced with Arrays.asList(allCiphers) or does the resulting List have to be modifiable?
| } | ||
| return listCiphers; |
There was a problem hiding this comment.
If all methods using filterCiphers convert the returned list to an array directly maybe that common part could be done here as well?
| return filterCiphers(ciphers, BIT_CIPHERS).toArray(new String[0]); | ||
| } | ||
|
|
||
| private static List<String> filterCiphers(List<String> ciphers, Set<String> filterList){ |
There was a problem hiding this comment.
If filterCiphers would take a Predicate<String> evaluating if a cipher is accepted all the filters could be done with the same function (breakUpCiphers could also use filter) and in one pass (breakUpCiphers would not needed to be called multiple times) and the code would be more readable formulating the condition of the ciphers to keep as a lambda. WDYT?
|
@jbee I have made the requested changes. |
Pandrex247
changed the title
|
Jenkins test please |
... with unsynchronized. extracted a method for code copy.
Apologies for the reformatting of one of the classes. The formatting was way off.
The replacement of the used Stack class in the inner class JsonChars is thread-safe because every call creates a new instance of the JsonChars class. Thus only a single thread will enter it.