PAYARA-3964 Allow configuration of MDB bean pool size with ActivationConfigProperty #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eployment descriptor elements as ActivationConfirProperty values
Mini change - added space
|
Jenkins test please |
arjantijms
changed the title
arjantijms
approved these changes
Jul 11, 2019
Pandrex247
reviewed
Jul 12, 2019
| @@ -114,7 +117,7 @@ protected EjbDescriptor createEjbDescriptor(String elementName, | |||
| * Set Annotation information to Descriptor. | |||
| * This method will also be invoked for an existing descriptor with | |||
| * annotation as user may not specific a complete xml. | |||
| * @param ejbDesc | |||
| * @param ejbDescMaxWaitTimeInMillis | |||
There was a problem hiding this comment.
Good catch, it's also not used for "MaxWaitTimeInMillis", so doesn't seem like a matter of forgetting to rename the method argument as well.
| @@ -142,6 +145,26 @@ protected HandlerProcessingResult setEjbDescriptorInfo( | |||
| // xml override | |||
| if (acProp.propertyName().equals("resourceAdapter")) { | |||
| ejbMsgBeanDesc.setResourceAdapterMid(envProp.getValue()); | |||
| } else if (acProp.propertyName().equals("MaxPoolSize")) { | |||
There was a problem hiding this comment.
Would a switch not be better?
|
Nothing immediately wrong from a quick glance, but a couple of quibbles |
| @@ -142,6 +145,26 @@ protected HandlerProcessingResult setEjbDescriptorInfo( | |||
| // xml override | |||
| if (acProp.propertyName().equals("resourceAdapter")) { | |||
| ejbMsgBeanDesc.setResourceAdapterMid(envProp.getValue()); | |||
| } else if (acProp.propertyName().equals("MaxPoolSize")) { | |||
There was a problem hiding this comment.
The default value for these properties is defined in appserver/deployment/dol/src/main/java/com/sun/enterprise/deployment/DescriptorConstants.java.
String constants should also be added for these properties name.
MattGill98
approved these changes
Jul 30, 2019
|
Review comments PR: smillidge#4 |
jGauravGupta
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for singleton-bean-pool and bean-pool MDB deployment descriptor elements as ActivationConfigProperty values in MDB annotations