Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-3918 Fixed typo in path. #3990

Merged
merged 1 commit into from
Jun 4, 2019
Merged

PAYARA-3918 Fixed typo in path. #3990

merged 1 commit into from
Jun 4, 2019

Conversation

johnmanko
Copy link
Contributor

No description provided.

@johnmanko johnmanko changed the title Fixed type in path. Fixed typepo in path. May 30, 2019
@johnmanko johnmanko changed the title Fixed typepo in path. Fixed typo in path. May 30, 2019
@smillidge
Copy link
Contributor

Thanks good catch

@johnmanko
Copy link
Contributor Author

johnmanko commented May 30, 2019 •
edited
Loading

I seems like there are a lot of places where META-INF, WEB-INF, *.xml strings are defined. I wouldn't mind consolidating all of those to a single definition class some place. If you're ok with that, I'll work on it. Which class/interface should define all of those? There is Payara/appserver/resources/resources-connector/src/main/java/org/glassfish/resources/api/ResourceConstants.java, but I think the current ones defined in there will also have to be renamed to account for WEB-INF. Perhaps move the definitions from Payara/appserver/resources/resources-connector/src/main/java/org/glassfish/resources/util/ResourceUtil.java to ResourceConstants.java?

@cubastanley
Copy link
Contributor

Jenkins test please

pdudits
pdudits suggested changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@pdudits pdudits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year on line 40 needs updating

@pdudits pdudits added the PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. label Jun 4, 2019
@pdudits
Copy link
Contributor

pdudits commented Jun 4, 2019 •
edited
Loading

@johnmanko, please check our contribution guide, and fill out the CLA.. Update: not needed for change this small.

Thanks for your contribution!

@pdudits pdudits removed the PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. label Jun 4, 2019
@pdudits pdudits merged commit a33d96a into payara:master Jun 4, 2019
@Pandrex247 Pandrex247 changed the title Fixed typo in path. PAYARA-3918 Fixed typo in path. Jun 12, 2019
@arjantijms arjantijms added this to the 5.193 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRoth AlanRoth AlanRoth approved these changes

@pdudits pdudits pdudits approved these changes

@jbee jbee jbee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.193
Development

Successfully merging this pull request may close these issues.
7 participants
@johnmanko @smillidge @cubastanley @pdudits @jbee @AlanRoth @arjantijms