PAYARA-3876 Added profiles for adding and embedding source in build #3987
Conversation
Signed-off-by: arjantijms <[email protected]>
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <executions> |
There was a problem hiding this comment.
Given the packaging process is complicated already, wouldn't be better to define those source-only steps in profile only?
There was a problem hiding this comment.
Lines 495 to 498 are in the embed-source profile, so the source-only steps are already in profile. Or did you mean something else?
There was a problem hiding this comment.
Yes, whether you considered configuration of this execution to be put here as well. The <phase>none</phase> is easy to miss when reasoning about what the actual process is.
There was a problem hiding this comment.
I put it there since that's how the IPS profile works too. All the config in one place, and then the profiles activate it.
Signed-off-by: arjantijms <[email protected]>
|
How is this different from |
This embeds the source inside the java jar archives, so the IDE always finds it. |
Signed-off-by: arjantijms <[email protected]>
|
Jenkins test please |
PAYARA-3876
Signed-off-by: arjantijms [email protected]