PAYARA-3521: Only trace JAX-RS Client requests when tracing services are present #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
approved these changes
May 18, 2019
|
Jenkins test please |
cubastanley
approved these changes
May 20, 2019
Cousjava
approved these changes
May 20, 2019
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
Jersey dependencies version upgrade (part II)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case in payara-samples#11
Root cause was, that open tracing decorator is present as ServiceLoader-visible service and intercepts creation of JAX-RS client, even if request tracing service (or any other service, as Payara is not running) is not available.