payara-3696-acc-executor-service #3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arjantijms <[email protected]>
Signed-off-by: arjantijms <[email protected]>
|
Jenkins test please |
pdudits
suggested changes
May 7, 2019
I think we'd seen those already then, as initialisation was already skipped, just with an NPE before. |
MattGill98
approved these changes
May 7, 2019
Signed-off-by: arjantijms <[email protected]>
|
Jenkins test please |
MattGill98
reviewed
May 7, 2019
| TimeUnit.valueOf(payaraExecutorServiceConfiguration.getThreadPoolExecutorKeepAliveTimeUnit()), | ||
| new LinkedBlockingQueue<>(threadPoolExecutorQueueSize), | ||
| (Runnable r) -> new Thread(r, "payara-executor-service-task")); | ||
| 0, |
There was a problem hiding this comment.
Is it possible to move the configured properties to local variables and override them if isAcc passes?
pdudits
approved these changes
May 8, 2019
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
fixes for Eclipse Jenkins environment (adaptopenjdk, shell etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payara-3696 Don't init executor service when in ACC
Hint for reviewers; review per individual commit. The first commit is adding a debug option to the ACC start, since it's otherwise quite difficult to debug the agent code for the ACC.
The second commit fixes the exception during startup of the ACC by not initialising the executor service on the client-side.