PAYARA-3419: Support deploying timers to deployment group and non-persistent timer service #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyment group Deployment Group does not refer to any specific configuration, therefore no timer service exists for the target.
This will use non-persistent timer -- all timers run only on node where they were created and not persist across restarts.
pdudits
commented
Mar 19, 2019
| @@ -98,7 +99,7 @@ | |||
| <sun:staticText id="msecs" style="padding: 8pt" text="$resource{i18n.common.Milliseconds}"/> | |||
| </sun:property> | |||
| <sun:property id="persistenceServiceProp" labelAlign="left" noWrap="#{true}" overlapLabel="#{false}" label="$resource{i18n_ejb.ejbTimerSettings.persistenceServiceLabel}" helpText="$resource{i18n_ejb.ejbTimerSettings.persistenceServiceHelp}" visible="#{true}" > | |||
| <sun:dropDown id="EjbTimerService" selected="#{pageSession.valueMap['ejbTimerService']}" required="#{false}" value="#{pageSession.valueMap['ejbTimerService']}" labels={"Database","DataGrid"} values={"Database","DataGrid"} > | |||
| <sun:dropDown id="EjbTimerService" selected="#{pageSession.valueMap['ejbTimerService']}" required="#{false}" value="#{pageSession.valueMap['ejbTimerService']}" labels={"Database","DataGrid","None"} values={"Database","DataGrid","None"} > | |||
Remains in config for compatibility reasons
|
jenkins test please |
Cousjava
approved these changes
Mar 20, 2019
rdebusscher
suggested changes
Mar 21, 2019
appserver/ejb/ejb-connector/src/main/java/org/glassfish/ejb/config/EjbTimerService.java
Outdated
Show resolved
Hide resolved
|
jenkins test please |
jGauravGupta
requested changes
Mar 22, 2019
| * Supported values: | ||
| * <ul> | ||
| * <li>{@value #TYPE_DATABASE} for database-backed persistence</li> | ||
| * <li>"DataGrid" for DataGrid-backed persistence</li> |
There was a problem hiding this comment.
Replace "DataGrid" with {@value #TYPE_DATAGRID}
| @@ -68,6 +68,8 @@ | |||
|
|
|||
| @Configured | |||
| public interface EjbTimerService extends ConfigBeanProxy, PropertyBag { | |||
| String TYPE_NONE = "None"; | |||
| String TYPE_DATABASE = "Database"; | |||
There was a problem hiding this comment.
Perhaps TYPE_DATAGRID constant can be added to list all timer types.
There was a problem hiding this comment.
The reason I included these two was, that these are special -- one is default, the other has special behaviour. There's nothing else in the code that would actually match against value DataGrid in the code, and changing the value would not affect the behavior of the server. Therefore I believe it would be misleading to bake it into API.
rdebusscher
approved these changes
Mar 22, 2019
jGauravGupta
approved these changes
Mar 25, 2019
Pandrex247
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asadmin deployno longer fails when application with timers are deployed to a deployment group.EJB Timer Service offers option of persistence type None, where all timers are treated like non-persistent (as in Web Profile / EJB Lite).