PAYARA-3386: Update login.conf with login module #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Handling of property maps as list of maps extracted to helper class
pdudits
commented
Mar 18, 2019
| attrMap.put("fileJaax", "fileRealm"); | ||
| attrMap.put("ldapJaax", "ldapRealm" ); | ||
| attrMap.put("solarisJaax", "solarisRealm"); | ||
| attrMap.put("jdbcJaax", "jdbcRealm"); |
| <sun:property id="loginModule" labelAlign="left" noWrap="#{true}" overlapLabel="#{false}" label="$resource{i18nc.realm.loginmodule.class}" helpText="$resource{i18nc.realm.loginmodule.classHelp}" > | ||
| <sun:textField id="loginModule" text="#{attrMap.loginModuleClass}" columns="$int{57}" maxLength="#{sessionScope.fieldLengths['maxLength.realm.Classname']}" /> | ||
| </sun:property> | ||
| </sun:propertySheetSection> |
| if (testtype.match('none')){ | ||
| var loginModuleJaax = document.getElementById('#{loginModuleJaax}'); | ||
|
|
||
| loginModuleJaax.style.display = 'none'; |
There was a problem hiding this comment.
For predefined classes, that already have an attribute for JAAS Context, it is not displayed for login module configuration:
|
jenkins test please |
arjantijms
suggested changes
Mar 18, 2019
Pandrex247
changed the title
|
jenkins test please |
Cousjava
suggested changes
Mar 20, 2019
arjantijms
approved these changes
Mar 22, 2019
|
Further to my review: the issue is that I did not supply all fields and the UI did not indicate that I needed to or throw an error when I submitted it |
|
@Cousjava, I improved the UI a bit, try again, please |
|
jenkins test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login Module registration can be requested via
--login-moduleparameter tocreate-auth-realm. In such case propertyjaas-contextis required for the realm.In the Admin UI, the default jaas context is now prefilled when creating a predefined realm. Login modules can be registered by enabling a checkbox and filling in the login module class name (and JAAS context if not provided by predefined class)