Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-3477-Upgrade-Eclipselink-to-2.7.4 #3711

Merged
merged 1 commit into from
Feb 25, 2019
Merged

PAYARA-3477-Upgrade-Eclipselink-to-2.7.4 #3711

merged 1 commit into from
Feb 25, 2019

Conversation

mulderbaba
Copy link
Contributor

No description provided.

@mulderbaba mulderbaba added this to the 5.191 milestone Feb 10, 2019
@mulderbaba mulderbaba self-assigned this Feb 10, 2019
@mulderbaba
Copy link
Contributor Author

jenkins test

1 similar comment
@mulderbaba
Copy link
Contributor Author

jenkins test

Pandrex247
Pandrex247 requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to be using our patched version of EclipseLink any more, were all of our fixes to EclipseLink fixed in upstream?
I'm not convinced they were and that the previous upgrade to vanilla 2.7.3 was also incorrect.

@mulderbaba
Copy link
Contributor Author

I'm not convinced they were and that the previous upgrade to vanilla 2.7.3 was also incorrect.

@Pandrex247 I only checked one version before, ok make sense, time to dig down the parchments to find out what's in or not.

@mulderbaba mulderbaba added the PR: DO NOT MERGE Don't merge PR until further notice label Feb 20, 2019
@mulderbaba mulderbaba force-pushed the PAYARA-3477-Upgrade-Eclipselink-to-2.7.4 branch from bd499da to 1cb7d26 Compare February 23, 2019 13:30
@mulderbaba mulderbaba force-pushed the PAYARA-3477-Upgrade-Eclipselink-to-2.7.4 branch from 1cb7d26 to e3c91ba Compare February 23, 2019 21:20
@mulderbaba
Copy link
Contributor Author

jenkins test

1 similar comment
@mulderbaba
Copy link
Contributor Author

jenkins test

@mulderbaba mulderbaba removed the PR: DO NOT MERGE Don't merge PR until further notice label Feb 24, 2019
@Pandrex247
Copy link
Member

Jenkins test please

@Pandrex247 Pandrex247 merged commit 007e33f into payara:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkWareham MarkWareham MarkWareham approved these changes

@MeroRai MeroRai MeroRai approved these changes

@Pandrex247 Pandrex247 Pandrex247 approved these changes

@Cousjava Cousjava Awaiting requested review from Cousjava

Assignees

@mulderbaba mulderbaba

Labels
None yet
Projects
None yet
Milestone
5.191
Development

Successfully merging this pull request may close these issues.
4 participants
@mulderbaba @Pandrex247 @MeroRai @MarkWareham