Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3344 Added System Property for Shutdown Grace Period #3702

Merged
merged 4 commits into from
Feb 12, 2019
Merged

PAYARA-3344 Added System Property for Shutdown Grace Period #3702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1d0b8e
added grace period system property to server and micro
jbee Feb 7, 2019
1e87e82
updated copyright header
jbee Feb 7, 2019
d03ad8c
removed unused imports
jbee Feb 7, 2019
287cd1f
extracted constant for grace property, added command line option for …
jbee Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...-micro/payara-micro-core/src/main/java/fish/payara/micro/boot/runtime/MicroGlassFish.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
*/
package fish.payara.micro.boot.runtime;

import com.sun.enterprise.glassfish.bootstrap.GlassFishImpl;
import com.sun.enterprise.module.bootstrap.ModuleStartup;
import java.util.Properties;
import org.glassfish.embeddable.CommandRunner;
Expand Down Expand Up @@ -74,19 +75,20 @@ public void start() throws GlassFishException {
}

@Override
public void stop() throws GlassFishException {
public synchronized void stop() throws GlassFishException {
if (status == Status.STOPPED || status == Status.STOPPING || status == Status.DISPOSED) {
throw new IllegalStateException("Already in " + status + " state.");
}

status = Status.STOPPING;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question is: after status is STOPPING will this prevent accepting new requests? I think the intention is to finish the ongoing ones but I guess we do not want to accept new ones.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow what the question is here?
There's a check literally above this that prints an error if multiple things try to stop the server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I wanted to point out is that before the wait only the status was changed. No internal processing has been signalled to stop by that point. I would imagine that it could very well be the case that new request still are accepted and start to process. If the goal with this feature is to give time to finish started requests it seams only consequent not to accept new ones. I would assume that some parts of the server needs to be stopped or flagged to get this behaviour.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching the source I don't see that status is used much other than to print it into the admin console. Perhaps we could use this status variable better to stop processing etc.However that would be a different JIRA.

GlassFishImpl.sleepShutdownGracePeriod();
kernel.stop();
habitat.shutdown();
status = Status.STOPPED;
}

@Override
public void dispose() throws GlassFishException {
public synchronized void dispose() throws GlassFishException {
if (status == Status.DISPOSED) {
throw new IllegalStateException("Already disposed.");
} else if (status != Status.STOPPED) {
Expand Down
17 changes: 17 additions & 0 deletions ...us/core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,13 @@
import org.glassfish.embeddable.Deployer;
import org.glassfish.embeddable.GlassFish;
import org.glassfish.embeddable.GlassFishException;
import org.glassfish.grizzly.threadpool.Threads;
import org.glassfish.hk2.api.ServiceLocator;

import java.util.Properties;

import javax.swing.plaf.SliderUI;
jbee marked this conversation as resolved.
Show resolved Hide resolved

/**
* @author [email protected]
*/
Expand Down Expand Up @@ -87,10 +90,24 @@ public synchronized void stop() throws GlassFishException {
throw new IllegalStateException("Already in " + status + " state.");
}
status = Status.STOPPING;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: do we prevent accepting new requests effectively?

sleepShutdownGracePeriod();
gfKernel.stop();
status = Status.STOPPED;
}

public static void sleepShutdownGracePeriod() {
String shutdowngrace = System.getProperty("fish.payara.shutdowngrace");
Pandrex247 marked this conversation as resolved.
Show resolved Hide resolved
if (shutdowngrace != null) {
try {
Thread.sleep(Integer.parseInt(shutdowngrace));
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
} catch (NumberFormatException e) {
// no sleep, continue shutdown
}
}
}

public synchronized void dispose() throws GlassFishException {
if (status == Status.DISPOSED) {
throw new IllegalStateException("Already disposed.");
Expand Down