-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-3247 Add NPN Version Switch #3414
PAYARA-3247 Add NPN Version Switch #3414
Conversation
jenkins test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a pretty neat solution. Although there will be a level of maintenance required to keep it up to date. We also need to remember to rip it out as part of the JDK 11+ work.
Any chance this all can be avoided just by using version support that now exists in the jvm-options tag in domain.xml? |
I've switched out the hard coded logic for the version support in the domain.xml, and fixed a bug that existed related to subversion comparison. Thanks @lprimak for pointing that out! |
@smillidge the new changes should make this a bit more maintainable, as it no longer affects any Java 9+ versions. The only reason we'd need to update this would be for new 8u192+ breaking changes. |
jenkins test please |
with todays update to openjdk version "1.8.0_252" this popped up again for 5.191. Not realy a problem for me, only sometimes use 5.191 locally, justletting you know |
These changes include several NPN jars, and code to dynamically select one when the asadmin start script runs. Ran manual tests:
start-domain
and then ping https://localhost:8181/ with OpenJDK 8u72 through to 8u192.