-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payara 3184 security support reset #3288
Merged
jGauravGupta
merged 5 commits into
payara:master
from
arjantijms:PAYARA-3184-security-support-reset
Oct 24, 2018
Merged
Payara 3184 security support reset #3288
jGauravGupta
merged 5 commits into
payara:master
from
arjantijms:PAYARA-3184-security-support-reset
Oct 24, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins test please |
Quick build and test failed! |
Signed-off-by: arjantijms <[email protected]>
Jenkins test please |
Quick build and test passed! |
jGauravGupta
requested changes
Oct 20, 2018
...ecurity/ssl-impl/src/main/java/com/sun/enterprise/security/ssl/impl/SecuritySupportImpl.java
Show resolved
Hide resolved
MattGill98
reviewed
Oct 23, 2018
...ecurity/ssl-impl/src/main/java/com/sun/enterprise/security/ssl/impl/SecuritySupportImpl.java
Outdated
Show resolved
Hide resolved
MattGill98
approved these changes
Oct 23, 2018
Jenkins test please |
Quick build and test passed! |
Changes look good to me! |
jGauravGupta
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAYARA-3184 made the SecuritySupport contract (responsible of certificate loading for SSL) resettable.