Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2764 Translate Payara only feature to Japanese #3259

Merged
merged 23 commits into from
Nov 2, 2018
Merged

PAYARA-2764 Translate Payara only feature to Japanese #3259

merged 23 commits into from
Nov 2, 2018

Conversation

khasunuma
Copy link

No description provided.

HASUNUMA Kenji and others added 20 commits July 23, 2018 03:27
add messages regarding to data grid and translate them to Japanese
72ba656
translate Data Grid configuration page (Japanese)
8bc3ea0
Merge branch 'master' of https://github.com/khasunuma/Payara into PAY…
73a1994 
…ARA-2764
PAYARA-2764 Add new properties
4fae3c7
Merge branch 'master' of https://github.com/payara/Payara into PAYARA…
a0d3851 
…-2764
PAYARA-2764 translate DG/DD pages to Japanese
3602078
PAYARA-2764 translate new features in existent pages to Japanese
d8952f9
PAYARA-2764 create and add new modules for localisation
8d95d8b
PAYARA-2764 modify description of additional packages
31169b3
PAYARA-2764 add osgi.bundle file to new modules
dd1e5f5
PAYARA-2764 add osgi.bundle file to new modules
4eb2902
PAYARA-2764 translate HealthCheck to Japanese
87831ad
PAYARA-2764 translate Monitor to Japanese
1723fbb
PAYARA-2764 translate JMX Monitoring to Japanese
9a875d6
PAYARA-2764 translate MicroProfile to Japanese
c53e15a
PAYARA-2764 translate Notification Service to Japanese
8e823a7
PAYARA-2764 fixed wrong dependencies
88e92da
PAYARA-2764 review translations
3487a87
PAYARA-2764 review translations
e9f487a
PAYARA-2764 fixed dependency (console-concurrent-plugin-l10n was corr…
aa0b1d9 
…ectly applied)
@arjantijms arjantijms requested a review from Pandrex247 October 12, 2018 10:50
@khasunuma
Copy link
Author

I consider alternative some plans regarding to this issue as follows:

  1. Reduce the resource bundle - Remove l10n resources without Japanese. (Probably, it works well)
  2. Divide the pull request - DD/DG (required) and Other features (Optional)

Introducing new l10n features required to create new many l10n modules. So the PR becomes often too large size. I think it's better that this PR should be divided to several PRs now.

Please let me know your suggestion about this PR. Then, I'll once withdraw the PR and create several PRs instead of this.

@khasunuma
Copy link
Author

I removed l10n resources without Japanese. Currently there are ja_JP resources into new modules.

MeroRai
MeroRai requested changes Oct 25, 2018
View reviewed changes
Copy link
Member

@MeroRai MeroRai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khasunuma, after a brief look below are the things I would like to raise:

  1. Copyright header year needs updating on most of the files.
  2. Unicode on some of the files have been capitalised, these will need to be reverted.

@MeroRai
Copy link
Member

MeroRai commented Oct 25, 2018

@khasunuma, forgot to mention, everything looks good on the admin console.

@MeroRai
Copy link
Member

MeroRai commented Oct 30, 2018

Jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

khasunuma
khasunuma commented Oct 31, 2018
View reviewed changes
Copy link
Author

@khasunuma khasunuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks well.

@payara payara deleted a comment from arjantijms Oct 31, 2018
@payara payara deleted a comment from payara-ci Oct 31, 2018
@payara payara deleted a comment from payara-ci Nov 1, 2018
@payara payara deleted a comment from arjantijms Nov 1, 2018
@arjantijms
Copy link
Contributor

Jenkins test please

3 similar comments
@Pandrex247
Copy link
Member

Jenkins test please

@arjantijms
Copy link
Contributor

Jenkins test please

@arjantijms
Copy link
Contributor

Jenkins test please

@arjantijms arjantijms merged commit 9c1eefe into payara:master Nov 2, 2018
@khasunuma khasunuma deleted the PAYARA-2764-admingui-translation-ja branch August 30, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeroRai MeroRai MeroRai approved these changes

@Pandrex247 Pandrex247 Awaiting requested review from Pandrex247

@jGauravGupta jGauravGupta Awaiting requested review from jGauravGupta

@MattGill98 MattGill98 Awaiting requested review from MattGill98

Assignees

@MeroRai MeroRai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khasunuma @MeroRai @payara-ci @arjantijms @Pandrex247