PAYARA-2627 remove X500 class #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and other parts of the code base
…o smillidge-PAYARA-2627
|
Jenkins test please |
|
Quick build and test passed! |
arjantijms
previously requested changes
Sep 27, 2018
| // Set the transport principal in subject and | ||
| // return the X500Principal class | ||
| securityContext = new SecurityContext(); | ||
| X500Principal x500Name = (X500Principal) certChain[0].getSubjectX500Principal(); |
There was a problem hiding this comment.
X500Principal x500principal
| @@ -207,7 +208,7 @@ public static void doX500Login(Subject subject, String appModuleID) throws Login | |||
| String user = null; | |||
| String realmName = null; | |||
| try { | |||
| X500Name x500name = getPublicCredentials(subject, X500Name.class); | |||
| X500Principal x500name = (X500Principal)getPublicCredentials(subject, X500Principal.class); | |||
There was a problem hiding this comment.
X500Principal x500Name
Plus, is cast needed?
| @@ -132,70 +132,69 @@ protected void init(Properties props) throws BadRealmException, NoSuchRealmExcep | |||
| * @return Description of the kind of authentication that is directly supported by this realm. | |||
| */ | |||
| @Override | |||
| public String getAuthType() { | |||
| public String getAuthType() | |||
| { | |||
| public void authenticate(Subject subject, X500Name x500name) { | ||
|
|
||
| public void authenticate(Subject subject, X500Principal x500name) | ||
| { |
| * | ||
| * @param subject The Subject object for the authentication request. | ||
| * @param x500name The X500Name object from the user certificate. | ||
| * | ||
| */ | ||
| public void authenticate(Subject subject, X500Name x500name) { | ||
|
|
||
| public void authenticate(Subject subject, X500Principal x500name) |
There was a problem hiding this comment.
X500Principal x500Principal
|
|
||
| if (!subject.getPrincipals().isEmpty()) { | ||
| subject.getPublicCredentials().add(new DistinguishedPrincipalCredential(x500name)); | ||
| DistinguishedPrincipalCredential dpc = new DistinguishedPrincipalCredential(x500name); |
There was a problem hiding this comment.
Don't use names like dpc, agy, opo, etc
In this case the intermediate variable also isn't really needed.
| v.add(groups[i]); | ||
| } | ||
| private void setGroupNames(String username, String[] groups) | ||
| { |
| } | ||
| private void setGroupNames(String username, String[] groups) | ||
| { | ||
| LinkedList v = new LinkedList(); |
There was a problem hiding this comment.
Avoid names like v, z, o, etc.
| } | ||
| } | ||
| grpList = addAssignGroups(grpList); | ||
| grpList = this.addMappedGroupNames(grpList); | ||
| setGroupNames(_username, grpList); | ||
|
|
||
| if (_logger.isLoggable(Level.FINE)) { | ||
| _logger.log(Level.FINE, "LDAP: login succeeded for: " + _username); | ||
| if(_logger.isLoggable(Level.FINE)){ |
There was a problem hiding this comment.
formatting; needs spaces
|
Jenkins test please |
|
Quick build and test failed! |
|
jenkins test please |
|
Quick build and test failed! |
|
Jenkins test please |
|
Quick build and test passed! |
|
Jenkins test please |
Pandrex247
approved these changes
Oct 4, 2018
|
Quick build and test passed! |
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Oct 4, 2018
PAYARA-2627 remove X500 class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.