PAYARA-3110 Made TracedInterceptor serializable #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a warning when persisting session scoped beans
|
Jenkins test please |
|
Quick build and test passed! |
smillidge
previously requested changes
Sep 20, 2018
|
Jenkins test please |
|
Quick build and test passed! |
|
@Cousjava You could keep the TracedInterceptor serializable if you don't inject the BeanManager but use CDI.getBeanManager() whenever the BeanManager is needed. |
mulderbaba
approved these changes
Sep 22, 2018
|
@smillidge @Cousjava @svendiedrichsen The concern regarding the bean manager is addressed by section 6.6.3 of the CDI spec:
See https://docs.jboss.org/cdi/spec/2.0-PFD/cdi-spec.html#passivation_capable_dependency |
|
Jenkins2 test please |
Pandrex247
approved these changes
Oct 12, 2018
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Oct 25, 2018
…store-error PAYARA-3110 Made TracedInterceptor serializable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a warning when persisting session scoped beans