Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields #3163

Merged
merged 6 commits into from
Oct 2, 2018

Conversation

MeroRai
Copy link
Member

@MeroRai MeroRai commented Sep 13, 2018

No description provided.

@MeroRai MeroRai added this to the Payara 5.184 milestone Sep 13, 2018
@MeroRai MeroRai self-assigned this Sep 13, 2018
@MeroRai MeroRai requested a review from MattGill98 September 13, 2018 16:41
for (Field field : clazz.getDeclaredFields()) {
processAnnotation(field, annotationClass, annotationFunction, altClass, altFunction,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we discussed removing this? This class would be best kept generic, moving the implementation specific logic into the handleParam methods.

@Pandrex247 Pandrex247 changed the title OpenAPI Doesn't Support @...Param Annotated Fields PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields Sep 14, 2018
@MeroRai
Copy link
Member Author

MeroRai commented Oct 1, 2018

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@MeroRai
Copy link
Member Author

MeroRai commented Oct 1, 2018

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@payara payara deleted a comment from smillidge Oct 2, 2018
@MattGill98 MattGill98 merged commit 4077ca3 into payara:master Oct 2, 2018
MeroRai pushed a commit to MeroRai/Payara that referenced this pull request Oct 3, 2018
PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields
MeroRai pushed a commit to MeroRai/Payara that referenced this pull request Oct 10, 2018
PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants