PAYARA-2548 OpenAPI 1.0 Implementation #2745
Conversation
|
jenkins test please |
|
Quick build and test passed! |
There was a problem hiding this comment.
I've reviewed the Payara internals pieces. @arjantijms can review the general code. Good job big piece of work!!
| } | ||
|
|
||
| private String getContextRoot(ApplicationInfo appInfo) { | ||
| return appInfo.getMetaData(WebBundleDescriptorImpl.class).getContextRoot(); |
There was a problem hiding this comment.
You can get a NPE here for example when deploying an EJB jar as getMetaData I believe can return null.
There was a problem hiding this comment.
No worries, I've just made a fix for that.
| path = "set-openapi-configuration", | ||
| description = "Sets the OpenAPI Configuration") | ||
| }) | ||
| public class SetOpenApiConfigurationCommand implements AdminCommand { |
There was a problem hiding this comment.
This command as written will require a restart to take effect. Can you make sure it indicates that in the administration console.
There was a problem hiding this comment.
How do you mean? From my testing, enabling and disabling the OpenAPI seems dynamic. I've moved the logging into the OpenAPIService to make it more obvious and readable.
|
Jenkins test |
|
Jenkins test please |
|
Quick build and test passed! |
|
Quick build and test passed! |
|
Jenkins test please |
|
Quick build and test passed! |
|
jenkins test please |
|
Quick build and test passed! |
…OpenAPI-1.0-REBASE PAYARA-2548 OpenAPI 1.0 Implementation
No description provided.