PAYARA-1394 OAuth 2 client integration #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not work due to OSGi issues
…jection in it fails
Fails to inject OAuth2State
OAuth integration now appears to work, but needs further testing
…is made to a secured page Also split up OAuthState so some methods are part of the public api
|
Jenkins test please |
|
Quick build and test passed! |
…-1394-oauth-client-integration
|
Jenkins test please |
|
Quick build and test passed! |
arjantijms
suggested changes
Apr 23, 2018
| * @return | ||
| */ | ||
| @Override | ||
| public CredentialValidationResult validate(Credential credentials){ |
There was a problem hiding this comment.
This method shouldn't be needed as the interface already contains a default method for this (indeed, examples still don't always use that interface method)
Cousjava
force-pushed
the
PAYARA-1394-oauth-client-integration
branch
from
60b6139 to
a9fb9ba
Compare
…-1394-oauth-client-integration
|
Quick build and test failed! |
|
Jenkins test please |
|
Quick build and test passed! |
arjantijms
approved these changes
Apr 25, 2018
Cousjava
added a commit
to Cousjava/Payara
that referenced
this pull request
Apr 26, 2018
* PAYARA-1394 OAuth2 integration - new annotation and handler for it * PAYARA-1394 Compiling version of basic mechanism Does not work due to OSGi issues * PAYARA-1394 resolved OSGi errors * PAYARA-1394 removed HK2 annotations, using pure CDi * PAYARA-1394 added import for annotation * PAYARA-1394 oauth mechanism handler successfuly created, although innjection in it fails * PAYARA-1394 Another way to produce the mechanism Fails to inject OAuth2State * PAYARA-1394 OAuth handler now works * PAYARA-1394 Added default identity store OAuth integration now appears to work, but needs further testing * PAYARA-1394 authentication mechanism is now only used when a request is made to a secured page Also split up OAuthState so some methods are part of the public api * PAYARA-1394 OAuth integration now only is called when necessary * PAYARA-1394 Split state into two files, added moduleinfo and javadoc comments * PAYARA-1394 minor bug fixes, now only use one logger name * PAYARA-1394 Added enviroment variable substitution for the annotation * PAYARA-1394 Correct scope name, remove extraenous code * PAYARA-1394 add comma in imports; fix incorrect merge
MarkWareham
reviewed
May 1, 2018
| * @return | ||
| */ | ||
| @NotNull | ||
| String authEndpoint(); |
There was a problem hiding this comment.
Please put a full name in here, not 'auth'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.