PAYARA-2477 Create asadmin commands for MicroProfile Metrics (Payara 5) #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick build and test failed! |
1 similar comment
|
Quick build and test failed! |
smillidge
requested changes
Feb 20, 2018
| @Service(name = "get-metrics-configuration") | ||
| @PerLookup | ||
| @ExecuteOn({RuntimeType.DAS}) | ||
| @TargetType({DAS, STANDALONE_INSTANCE, CLUSTER, CLUSTERED_INSTANCE, CONFIG}) |
There was a problem hiding this comment.
Requires Deployment Group Target Type in Payara 5
jGauravGupta
changed the title
|
Jenkins, quick test Payara 5 please |
|
Quick build and test passed! |
|
Perhaps close this and just depend on the commit for Payara 4 to be merged to 5? |
|
It needs separate PRs due to the target type of Deployment Group |
smillidge
requested changes
Feb 24, 2018
| @@ -0,0 +1,74 @@ | |||
| /* | |||
There was a problem hiding this comment.
Can you add an empty tag to the domain.xml for each config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.