Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2440 Refactor Pretty Date Format #2424

Merged
merged 7 commits into from
Feb 23, 2018
Merged

PAYARA-2440 Refactor Pretty Date Format #2424

merged 7 commits into from
Feb 23, 2018

Conversation

MattGill98
Copy link
Contributor

No description provided.

@MattGill98 MattGill98 requested a review from Cousjava February 19, 2018 13:02
@MattGill98
Copy link
Contributor Author

jenkins quick test payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

smillidge
smillidge requested changes Feb 20, 2018
View reviewed changes
...ngui/payara-console-extras/src/main/java/fish/payara/admingui/extras/PayaraUtilHandlers.java Outdated
result = DateFormat.getDateTimeInstance().format(new Date(Long.valueOf(value)));
} catch (NullPointerException ex) {
result = "The input value was null.";
ex.printStackTrace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be log messages rather than just dumping the stack

@smillidge smillidge added this to the Payara 5.181 milestone Feb 22, 2018
@smillidge
Copy link
Contributor

Fixes #2216

@smillidge
Copy link
Contributor

jenkins quick test payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@arjantijms
Copy link
Contributor

jenkins quick test payara 5 please

@arjantijms
Copy link
Contributor

jenkins quick test payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

1 similar comment
@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge smillidge merged commit a8bcfc3 into payara:Payara-5 Feb 23, 2018
@smillidge smillidge mentioned this pull request Feb 24, 2018
Closed
@MattGill98 MattGill98 mentioned this pull request Feb 26, 2018
Merged
smillidge pushed a commit that referenced this pull request Feb 26, 2018
@MattGill98 @smillidge
PAYARA-2440 Refactor Pretty Date Format (#2424) (#2462)
520a712 
* Added null check to prettyDateFormat.

* Properly handled the exceptions.

* Added copyright header.
@MattGill98 MattGill98 deleted the PAYARA-2440-Refactor-PrettyDateFormat branch June 18, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smillidge smillidge smillidge approved these changes

@Cousjava Cousjava Cousjava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 5.181
Development

Successfully merging this pull request may close these issues.
6 participants
@MattGill98 @payara-ci @smillidge @arjantijms @Cousjava @fturizo