-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-1079 Add DataGrid Timer Store #2394
Conversation
Jenkins, quick test Payara 5 please |
Quick build and test passed! |
Jenkins, quick test Payara 5 please |
Quick build and test passed! |
extraProperties = new Properties(); | ||
actionReport.setExtraProperties(extraProperties); | ||
} | ||
List<Map<String,String>> property = new LinkedList <>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, but formatting; space too much after List
for (int i = 0; i < serverIds.length; i++) { | ||
final ActionReport.MessagePart part = report.getTopMessagePart().addChild(); | ||
part.setMessage(serverIds[i] + ": " + timerCounts[i]); | ||
HashMap<String,String> values = new HashMap<>(); | ||
values.put("server", serverIds[i]); | ||
values.put("timerCount",timerCounts[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor thing, but formatting; but could do with extra space before timerCounts[i]
return s0.getName(); | ||
// If target is a cluster or deployment group replace it with the instance | ||
List<Server> instances = Collections.EMPTY_LIST; | ||
Cluster c = domain.getClusterNamed(target); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to avoid single letter variable names or in general short uncommon abbreviations. Best to use "cluster" here instead of "c".
Persistence Service is selectable in the administration console
…ata grid for all deployed applications
…d datagrid persistence mode. Clustered failover works in Datagrid
22889fa
to
a19d7ed
Compare
Minor white space changes done |
Jenkins, quick test Payara 5 please |
Jenkins, quick test Payara 5 please |
Quick build and test passed! |
Jenkins, quick test Payara 5 please |
Quick build and test passed! |
Fixes #1112