Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1079 Add DataGrid Timer Store #2394

Merged
merged 10 commits into from
Feb 18, 2018
Merged

Conversation

smillidge
Copy link
Contributor

Fixes #1112

@smillidge
Copy link
Contributor Author

Jenkins, quick test Payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge smillidge added this to the Payara 5.181 milestone Feb 14, 2018
@smillidge
Copy link
Contributor Author

Jenkins, quick test Payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

extraProperties = new Properties();
actionReport.setExtraProperties(extraProperties);
}
List<Map<String,String>> property = new LinkedList <>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but formatting; space too much after List

for (int i = 0; i < serverIds.length; i++) {
final ActionReport.MessagePart part = report.getTopMessagePart().addChild();
part.setMessage(serverIds[i] + ": " + timerCounts[i]);
HashMap<String,String> values = new HashMap<>();
values.put("server", serverIds[i]);
values.put("timerCount",timerCounts[i]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor thing, but formatting; but could do with extra space before timerCounts[i]

return s0.getName();
// If target is a cluster or deployment group replace it with the instance
List<Server> instances = Collections.EMPTY_LIST;
Cluster c = domain.getClusterNamed(target);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to avoid single letter variable names or in general short uncommon abbreviations. Best to use "cluster" here instead of "c".

@smillidge
Copy link
Contributor Author

smillidge commented Feb 17, 2018

Minor white space changes done

@smillidge
Copy link
Contributor Author

Jenkins, quick test Payara 5 please

@arjantijms
Copy link
Contributor

Jenkins, quick test Payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge
Copy link
Contributor Author

Jenkins, quick test Payara 5 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@arjantijms arjantijms merged commit 3cf4f61 into payara:Payara-5 Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants