PAYARA-2341 repackage JCIP annotations with OSGi headers #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
|
Quick build and test passed! |
lprimak
approved these changes
Dec 15, 2017
|
Can you add an entry in https://github.com/payara/Payara/blob/master/appserver/packager/legal/src/main/resources/glassfish/legal/PAYARA-3RD-PARTY-LICENSE.txt if this is a new 3rd party dependency being packaged into Payara |
Pandrex247
previously requested changes
Dec 18, 2017
| <artifactItem> | ||
| <groupId>com.github.stephenc.jcip</groupId> | ||
| <artifactId>jcip-annotations</artifactId> | ||
| <version>1.0-1</version> |
There was a problem hiding this comment.
Please define and use a version property from appserver/pom.xml
|
jenkins test please |
|
Quick build and test passed! |
michaelranaldo
pushed a commit
to michaelranaldo/Payara
that referenced
this pull request
Jan 8, 2018
* PAYARA-2341 repackage JCIP annotations with OSGi headers * PAYARA-2341 Addressing feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAYARA-2341 creates a JCIP jar with the OSGi headers in MANIFEST.MF, but does not yet add this as a dependency to Payara.